mayankkunwar commented on PR #4630: URL: https://github.com/apache/hive/pull/4630#issuecomment-1696686928
> I dont have a 100% understanding of this issue but Im curious if there are other ways to fix this, as this https://issues.apache.org/jira/browse/HIVE-17350 ticket mentioned that this issue is caused when `retries happen when HS2 init fails`. The root cause to me seems like Metrics source is not gracefully shutdown when HS2 init fails, rather than shutting down the metric in `initCodahaleMetricsReporterClasses()`. Should we add logic to gracefully shutdown the Metrics reporter when there is a HS2 init failure. @mayankkunwar @abstractdog WDYT @akshat0395 Actually I was only able to reproduce this issue using the unit test. Otherwise it is very difficult to reproduce this issue in the cluster. But this issue is currently faced by the customer. Whenever they restart HS2 service, they encounter the runtime exception. But if they restarts the whole cluster everything works fine. I tried the gracefully shutdown method also by shutting down in the close() method, but it does not cover all the scenarios. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
