deniskuzZ commented on code in PR #4384:
URL: https://github.com/apache/hive/pull/4384#discussion_r1310037354
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -6246,18 +6303,24 @@ public void releaseLocks(Long timestamp) {
LOG.warn("Unable to update MT_KEY2 value for MT_KEY1=" + key, ex);
rollbackDBConn(dbConn);
}
- close(rs, stmt, dbConn);
+ TxnHandler.close(rs, stmt, dbConn);
if(derbySemaphore != null) {
derbySemaphore.release();
}
if (LOG.isDebugEnabled()) {
LOG.debug("{} unlocked by {}", quoteString(key),
quoteString(TxnHandler.hostname));
}
}
+
+ @Override
+ public void close() {
+ releaseLocks();
+ }
+
}
- private static class NoPoolConnectionPool implements DataSource {
+ public static class NoPoolConnectionPool implements DataSource {
Review Comment:
does it have to be public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
