deniskuzZ commented on code in PR #4384:
URL: https://github.com/apache/hive/pull/4384#discussion_r1310070413
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -1603,21 +1645,24 @@ public void commitTxn(CommitTxnRequest rqst) throws
NoSuchTxnException, TxnAbort
}
if (!isHiveReplTxn) {
- createCommitNotificationEvent(dbConn, txnid , txnType);
+ createCommitNotificationEvent(jdbcTemplate, txnid , txnType);
}
LOG.debug("Going to commit");
- dbConn.commit();
+ jdbcTemplate.commit();
if (MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.METASTORE_ACIDMETRICS_EXT_ON)) {
Metrics.getOrCreateCounter(MetricsConstants.TOTAL_NUM_COMMITTED_TXNS).inc();
}
} catch (SQLException e) {
LOG.debug("Going to rollback: ", e);
- rollbackDBConn(dbConn);
+ jdbcTemplate.rollback();
Review Comment:
i don't get it, we did refactor in some methods, replaced retry with
retryhandler and used jdbctemplatewrapper. here we just using jdbcTemplate to
access the connection object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
