[GitHub] [hive] Diksha628 commented on a diff in pull request #4636: HIVE-27324: Hive query with NOT IN condition is giving incorrect results when the sub query table contains the null value

[via GitHub]

Diksha628 commented on code in PR #4636:
URL: https://github.com/apache/hive/pull/4636#discussion_r1316083994


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -3603,7 +3603,20 @@ private Operator genFilterPlan(ASTNode searchCond, QB 
qb, Operator input,
          * push filters only for this QBJoinTree. Child QBJoinTrees have 
already been handled.
          */
         pushJoinFilters(qb, joinTree, aliasToOpInfo, false);
-        input = genJoinOperator(qbSQ, joinTree, aliasToOpInfo, input);
+        boolean notInCheck = (subQuery.getNotInCheck() != null)?true : false;
+        if(notInCheck && !qb.isMultiDestQuery()){

Review Comment:
   The code block with the notInCheck at that line, handles the not in operator 
such that if subquery table.col_referenced has a null value, output will be 
empty. The code block added in this PR aligns with the behaviour of queries 
with "IN"  operator, where the null not in case is handled during join time by 
adding a predicate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org