[GitHub] [hive] Diksha628 commented on a diff in pull request #4636: HIVE-27324: Hive query with NOT IN condition is giving incorrect results when the sub query table contains the null value

[via GitHub]

Diksha628 commented on code in PR #4636:
URL: https://github.com/apache/hive/pull/4636#discussion_r1323999447


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -3742,6 +3755,80 @@ private Operator genNotNullFilterForJoinSourcePlan(QB 
qb, Operator input,
     return output;
   }
 
+  /** This function is used for the purpose of adding an
+   *  outerQueryTable.outerQueryCol is not null predicate to the join,
+   *  since it is not added naturally like it is done in the case of "IN" 
operator
+   **/
+  private Operator genNotNullFilterForJoinSourcePlanNIC(QB qb, Operator input,

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org