abstractdog commented on code in PR #4683:
URL: https://github.com/apache/hive/pull/4683#discussion_r1322657698
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java:
##########
@@ -103,6 +103,7 @@ public void checkQueueAccess(
});
} catch (Exception exception) {
LOG.error("Cannot check queue access against UGI: " + ugi, exception);
+ throw exception;
Review Comment:
1. what's the point of catching and throwing further? you catch everything,
and throw them further but only specifying IOException and InterruptedException
in the method signature ?
2. please clarify with a code comment what exactly throwing IOException /
InterruptedException means and what is the client of this method supposed to do
with them!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
