abstractdog commented on PR #4683: URL: https://github.com/apache/hive/pull/4683#issuecomment-1785538468
sorry guys, this is a -1 from my side at the moment can we add a unit test with code comments about what was broken? this kind of magic fix can be wiped out easily again I remember I asked for clarification as a code comment, I believe that: either code comment or unit test is fine, both of them if cool, none of them is not acceptable here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
