okumin commented on code in PR #4731:
URL: https://github.com/apache/hive/pull/4731#discussion_r1341960602
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -850,6 +851,10 @@ public static enum ConfVars {
HIVEIGNOREMAPJOINHINT("hive.ignore.mapjoin.hint", true, "Ignore the
mapjoin hint"),
+ HIVE_CONF_LOCKED_LIST("hive.conf.locked.list", "", "Comma separated " +
+ "list of configuration options which are locked and can not be
changed at runtime. Warning is logged and the " +
+ "change is ignored when user try to set these configs during
runtime"),
Review Comment:
Looks like, that's because
`hive.security.authorization.sqlstd.confwhitelist` is configured only by only a
specific authorizer. I think it is better to put `hive.conf.locked.list` in
`HiveConf#setupRestrictList` so that users using another authorizer can also
use this feature safely.
https://github.com/apache/hive/blob/rel/release-4.0.0-beta-1/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java#L6909-L6914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
