okumin commented on code in PR #4731: URL: https://github.com/apache/hive/pull/4731#discussion_r1344360267
########## common/src/java/org/apache/hadoop/hive/conf/HiveConf.java: ########## @@ -850,6 +851,10 @@ public static enum ConfVars { HIVEIGNOREMAPJOINHINT("hive.ignore.mapjoin.hint", true, "Ignore the mapjoin hint"), + HIVE_CONF_LOCKED_LIST("hive.conf.locked.list", "", "Comma separated " + + "list of configuration options which are locked and can not be changed at runtime. Warning is logged and the " + + "change is ignored when user try to set these configs during runtime"), Review Comment: Looks good. ``` 0: jdbc:hive2://hive-hiveserver2:10000/defaul> set hive.conf.locked.list; +----------------------------------------------+ | set | +----------------------------------------------+ | hive.conf.locked.list=hive.execution.engine | +----------------------------------------------+ 1 row selected (0.012 seconds) 0: jdbc:hive2://hive-hiveserver2:10000/defaul> set hive.conf.locked.list=hive.auto.convert.join; Error: Error while processing statement: Cannot modify hive.conf.locked.list at runtime. It is in the list of parameters that can't be modified at runtime or is prefixed by a restricted variable (state=42000,code=1) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org