simhadri-g commented on code in PR #4777: URL: https://github.com/apache/hive/pull/4777#discussion_r1352977575
########## ql/src/test/queries/clientpositive/test_unixtimestamp_for_invaild_dates.q: ########## @@ -0,0 +1,20 @@ +DESCRIBE FUNCTION UNIX_TIMESTAMP; Review Comment: Sure , i have added the patterns in `TestGenericUDFToUnixTimestampEvaluateStringStringCsv` . Also i will remove this q file which is now redundant because all the cases are covered in the csv. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
