simhadri-g commented on code in PR #4777:
URL: https://github.com/apache/hive/pull/4777#discussion_r1355698666
##########
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/InstantFormatter.java:
##########
@@ -56,16 +57,16 @@ InstantFormatter newFormatter(ZoneId zone) {
*/
DATETIME {
@Override
- InstantFormatter newFormatter(ZoneId zone) {
- return new InstantDateTimeFormatter(zone);
+ InstantFormatter newFormatter(ZoneId zone, ResolverStyle resolverStyle) {
+ return new InstantDateTimeFormatter(zone, resolverStyle);
}
};
/**
* Creates a new formatter with the specified zone id.
* @param zone - the zone id
* @return a new formatter with the specified zone id.
*/
- abstract InstantFormatter newFormatter(ZoneId zone);
+ abstract InstantFormatter newFormatter(ZoneId zone, ResolverStyle
resolverStyle);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
