SourabhBadhya commented on PR #4821: URL: https://github.com/apache/hive/pull/4821#issuecomment-1778943490
Hi @hzxiongyinke, Consider adding tests in the files where SessionState is tested. A potential candidate for adding such tests is `TestSessionState`. But feel free to add tests at relevant places as you wish. I dont think QTests is going to help much here, since it's primarily used for query output correctness. But let me know if you need help on writing QTests for this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
