hzxiongyinke commented on PR #4821:
URL: https://github.com/apache/hive/pull/4821#issuecomment-1786376663

   > @hzxiongyinke , I would say it would be great to have integration test but 
having unit tests around whether the HMS token is added to the UGI would also 
be fine.
   > 
   > You can simulate a lot of these logic by first constructing `conf` objects 
and adding the desired properties to it as needed and then expecting that in 
the UGI. You can also mock objects and make it pass through the logic and 
assert the expected method calls / values.
   
   @SourabhBadhya 
   I have finished writing my unit test cases, which are located in the 
directory itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/session. I 
plan to use the command "mvn test -Dtest=xxx" to test them, but I found that 
the Test Cases were not triggered. Later, I discovered that the 
maven-surefire-plugin was missing in the hive-unit pom.xml. Is what I am doing 
correct?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to