deniskuzZ commented on code in PR #4832:
URL: https://github.com/apache/hive/pull/4832#discussion_r1393908534
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -264,27 +248,16 @@ WHEN NOT MATCHED THEN INSERT VALUES (source.a2, source.b2)
updateOutputs(targetTable);
}
- /**
- * This sets the destination name prefix for update clause.
- * @param insClauseIdx index of insert clause in the rewritten multi-insert
represents the merge update clause.
- * @param rewrittenCtx the {@link Context} stores the prefixes
- * @return the number of prefixes set.
- */
- protected int addDestNamePrefixOfUpdate(int insClauseIdx, Context
rewrittenCtx) {
- rewrittenCtx.addDestNamePrefix(insClauseIdx,
Context.DestClausePrefix.UPDATE);
- return 1;
- }
-
/**
* If there is no WHEN NOT MATCHED THEN INSERT, we don't outer join.
*/
- private String chooseJoinType(List<ASTNode> whenClauses) {
+ private boolean hasWhenNotMatchedInsertClause(List<ASTNode> whenClauses) {
Review Comment:
👍
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -264,27 +248,16 @@ WHEN NOT MATCHED THEN INSERT VALUES (source.a2, source.b2)
updateOutputs(targetTable);
}
- /**
- * This sets the destination name prefix for update clause.
- * @param insClauseIdx index of insert clause in the rewritten multi-insert
represents the merge update clause.
- * @param rewrittenCtx the {@link Context} stores the prefixes
- * @return the number of prefixes set.
- */
- protected int addDestNamePrefixOfUpdate(int insClauseIdx, Context
rewrittenCtx) {
- rewrittenCtx.addDestNamePrefix(insClauseIdx,
Context.DestClausePrefix.UPDATE);
- return 1;
- }
-
/**
* If there is no WHEN NOT MATCHED THEN INSERT, we don't outer join.
*/
- private String chooseJoinType(List<ASTNode> whenClauses) {
+ private boolean hasWhenNotMatchedInsertClause(List<ASTNode> whenClauses) {
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
