deniskuzZ commented on code in PR #4832:
URL: https://github.com/apache/hive/pull/4832#discussion_r1393908970
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -295,72 +268,27 @@ private String chooseJoinType(List<ASTNode> whenClauses) {
* cardinality_violation() UDF throws an error whenever it's called killing
the query
* @return true if another Insert clause was added
*/
- private boolean handleCardinalityViolation(StringBuilder rewrittenQueryStr,
ASTNode target,
- String onClauseAsString, Table targetTable, boolean
onlyHaveWhenNotMatchedClause, ColumnAppender columnAppender)
- throws SemanticException {
+ private boolean handleCardinalityViolation(boolean
onlyHaveWhenNotMatchedClause) {
Review Comment:
👍
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -295,72 +268,27 @@ private String chooseJoinType(List<ASTNode> whenClauses) {
* cardinality_violation() UDF throws an error whenever it's called killing
the query
* @return true if another Insert clause was added
*/
- private boolean handleCardinalityViolation(StringBuilder rewrittenQueryStr,
ASTNode target,
- String onClauseAsString, Table targetTable, boolean
onlyHaveWhenNotMatchedClause, ColumnAppender columnAppender)
- throws SemanticException {
+ private boolean handleCardinalityViolation(boolean
onlyHaveWhenNotMatchedClause) {
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
