abstractdog commented on code in PR #4566: URL: https://github.com/apache/hive/pull/4566#discussion_r1398831631
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/ParameterizedBatchCommand.java: ########## @@ -0,0 +1,61 @@ +/* Review Comment: maybe it's just a matter taste, but I feel that an interface should go into the same package where it's typically implemented by many classes, if that package is typically about to contain those particular classes, so instead of having org.apache.hadoop.hive.metastore.txn.jdbc.ParameterizedBatchCommand and its subclasses in org.apache.hadoop.hive.metastore.txn.impl.commands, all of them can go into a package "org.apache.hadoop.hive.metastore.txn.command" what do you think? and the same applies to functions and other stuff introduced in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
