veghlaci05 commented on code in PR #4566: URL: https://github.com/apache/hive/pull/4566#discussion_r1399121112
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/ParameterizedBatchCommand.java: ########## @@ -0,0 +1,61 @@ +/* Review Comment: I was thinking the other way around: These interfaces and abstract classes are parameters in the various overloads of `MultiDataSourceJdbcResource.execute()` methods. Therefore I thought these should be in the same package as these classes together form the "API" to use by `[Compaction]TxnHandler` function implementations. However, I'm not strictly tied to this idea, as it doesn't really matter in which of these packages we put them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
