zhangbutao commented on code in PR #4915:
URL: https://github.com/apache/hive/pull/4915#discussion_r1415300846
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -5542,6 +5542,12 @@ private void replaceFiles(Path tablePath, Path srcf,
Path destf, Path oldPath, H
throw new HiveException("Getting globStatus " + srcf.toString(), e);
}
+ // in insert overwrite table query for partitions not in metastore but
exist in filesystem,
+ // oldPath is null and destination directory needs to cleaned up
Review Comment:
Good catch! You need to clarify that this issue can appear in case of
`TBLPROPERTIES ("external.table.purge"="false")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
