zhangbutao commented on code in PR #4915:
URL: https://github.com/apache/hive/pull/4915#discussion_r1418689062


##########
data/files/table.txt:
##########
@@ -0,0 +1,2 @@
+a

Review Comment:
   I think we can reuse the existing text file. such as `kv1.txt`



##########
ql/src/test/queries/clientpositive/load_drop_partition.q:
##########
@@ -0,0 +1,24 @@
+dfs -cp ${system:hive.root}/data/files/table.txt ${system:test.tmp.dir}/;
+

Review Comment:
   I think one qfile is enough. Let's test all the cases in 
`insert_overwrite_drop_partition.q`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to