deniskuzZ commented on code in PR #4935:
URL: https://github.com/apache/hive/pull/4935#discussion_r1422330473
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SplitGrouper.java:
##########
@@ -71,7 +71,7 @@ public class SplitGrouper {
// TODO This needs to be looked at. Map of Map to Map... Made concurrent for
now since split generation
// can happen in parallel.
- private static final Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>>
cache =
+ private final Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>> cache =
Review Comment:
@BsoBird, with that change the whole caching construct is useless when we
have multiple SplitGrouper instances.
The issue is with concurrent Hashtable.equals(). What if we change the type
of PartitionDesc.properties to HashMap or use non-synchronized equals?
````
Maps.difference(properties1, properties2).areEqual()
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
