BsoBird commented on code in PR #4935:
URL: https://github.com/apache/hive/pull/4935#discussion_r1423317195
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SplitGrouper.java:
##########
@@ -71,7 +71,7 @@ public class SplitGrouper {
// TODO This needs to be looked at. Map of Map to Map... Made concurrent for
now since split generation
// can happen in parallel.
- private static final Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>>
cache =
+ private final Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>> cache =
Review Comment:
@deniskuzZ
The third option is exactly the one you described:
PartitionDesc.equals::
```
Properties properties1 = getProperties();
Properties properties2 = other.getProperties();
cond = (properties1 == null && properties2 == null) ||
(properties1 != null &&
Maps.difference(properties1,properties2).areEqual());
if (!cond) {
return false;
}
```
After comparing these options, I prefer the modification you proposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
