InvisibleProgrammer commented on PR #4936: URL: https://github.com/apache/hive/pull/4936#issuecomment-1854336692
Firstly, I agree with @aturoczy , it is better to educate the users about a month is an integer type so please use integer types when you work with month. I have two concerns about this change: - Now it introduces a decimal -> integer conversation. (Side note, for the first sight, it looks like it would work with decimal -> short conversation as well). Can that extra conversation cause a performance overhead? - It modifies `GenericUDF.obtainIntConverter`. It is used in 4 other classes as well. Does it means that change adds decimal support for those as well? <img width="955" alt="image" src="https://github.com/apache/hive/assets/1486749/71744d86-ca52-488b-9819-973db91ea95c";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
