soumyakanti3578 commented on code in PR #4936:
URL: https://github.com/apache/hive/pull/4936#discussion_r1425676200
##########
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java:
##########
@@ -351,8 +352,12 @@ protected void obtainIntConverter(ObjectInspector[]
arguments, int i,
case INT:
case VOID:
break;
+ case DECIMAL:
+ if (inOi.scale() == 0) {
+ break;
+ }
Review Comment:
Yes, I agree that we should limit precision. Since we are using `add(int
field, int amount)` method of `java.util.Calendar`, where the `amount` type is
an `int`, I think we should limit the value to max value of an int.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
