zhangbutao commented on code in PR #4984:
URL: https://github.com/apache/hive/pull/4984#discussion_r1463047089
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -725,7 +725,7 @@ struct SetPartitionsStatsRequest {
2: optional bool needMerge, //stats need to be merged with the existing stats
3: optional i64 writeId=-1, // writeId for the current query that
updates the stats
4: optional string validWriteIdList, // valid write id list for the table for
which this struct is being sent
-5: required string engine //engine creating the current request
+5: optional string engine = "hive" //engine creating the current request
Review Comment:
That doesn't work. `required `will enforce check `engine `field in
construction method though it has a default value. For some others
framework(Trino) will use this class `SetPartitionsStatsRequest` but don't want
to care the `engine `field, and they just reuse hive stats.
`optional `has no any problem in current hive code. only need partial trival
changes in `HiveMetaStoreClient.java`. I think it is safe. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
