okumin commented on code in PR #4984:
URL: https://github.com/apache/hive/pull/4984#discussion_r1467677076
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -725,7 +725,7 @@ struct SetPartitionsStatsRequest {
2: optional bool needMerge, //stats need to be merged with the existing stats
3: optional i64 writeId=-1, // writeId for the current query that
updates the stats
4: optional string validWriteIdList, // valid write id list for the table for
which this struct is being sent
-5: required string engine //engine creating the current request
+5: optional string engine = "hive" //engine creating the current request
Review Comment:
Though I am not familiar with Thrift, I expect the following behaviors.
| Client protocol | HMS version | Behavior |
|-|-|-|
| Hive 3 (no engine is set) | Hive 4 w/o HIVE-27984 | Error |
| Hive 4 w/o HIVE-27984 | Hive 4 w/o HIVE-27984 | The engine type specified
by the client is used |
| Hive 4 w/ HIVE-27984 | Hive 4 w/o HIVE-27984 | The engine type specified
by the client is used. Error is a client nullified `engine` explicitly? |
| Hive 3 (no engine is set) | Hive 4 w/ HIVE-27984 | engine=hive |
| Hive 4 w/o HIVE-27984 | Hive 4 w/ HIVE-27984 | The engine type specified
by the client is used |
| Hive 4 w/ HIVE-27984 | Hive 4 w/ HIVE-27984 | The engine type specified by
the client is used. `engine-hive` if a client nullifies `engine` explicitly? |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
