amansinha100 commented on code in PR #5053:
URL: https://github.com/apache/hive/pull/5053#discussion_r1474678049
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/AlterMaterializedViewRebuildAnalyzer.java:
##########
@@ -480,8 +460,6 @@ protected ASTNode fixUpAfterCbo(ASTNode originalAst,
ASTNode newAst, CalcitePlan
fixUpASTAggregateInsertDeleteIncrementalRebuild(fixedAST,
getMaterializedViewASTBuilder());
return fixedAST;
case JOIN_INSERT_DELETE_REBUILD:
- fixUpASTJoinInsertDeleteIncrementalRebuild(fixedAST,
getMaterializedViewASTBuilder());
- return fixedAST;
Review Comment:
Ok, just for my reference, for the non-groupby queries that this patch is
addressing, could you point to where the fall back to the full rebuild (using
insert-overwrite) happens ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
