zabetak commented on code in PR #5053:
URL: https://github.com/apache/hive/pull/5053#discussion_r1482807644
##########
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_5.q:
##########
@@ -11,6 +11,8 @@ set hive.materializedview.rewriting=true;
create table cmv_basetable_n6 (a int, b varchar(256), c decimal(10,2), d int)
stored as orc TBLPROPERTIES ('transactional'='true');
insert into cmv_basetable_n6 values
+ (1, 'alfred', 10.30, 2),
+ (1, 'alfred', 10.30, 2),
Review Comment:
Instead of modifying existing tests to add duplicates in order to trigger
the problem I think it would be better to add a new minimal test like the one
you posted last under the JIRA ticket.
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/AlterMaterializedViewRebuildAnalyzer.java:
##########
@@ -480,8 +460,6 @@ protected ASTNode fixUpAfterCbo(ASTNode originalAst,
ASTNode newAst, CalcitePlan
fixUpASTAggregateInsertDeleteIncrementalRebuild(fixedAST,
getMaterializedViewASTBuilder());
return fixedAST;
case JOIN_INSERT_DELETE_REBUILD:
- fixUpASTJoinInsertDeleteIncrementalRebuild(fixedAST,
getMaterializedViewASTBuilder());
- return fixedAST;
Review Comment:
Since `JOIN_INSERT_DELETE_REBUILD` is not used anymore why not remove it
altogether?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
