okumin commented on PR #5037: URL: https://github.com/apache/hive/pull/5037#issuecomment-1924100180
@kgyrtkirk > I believe the link should be allowed - but in this the merge should be allowed due to the fact that these things represent the same thing. I guess this mentions the link on creating a FilterOperator? > I see now why the signature become an obstacle - I believe the SWO was able to match the same plan-parts to only scan the table once; if you don't have link calls there to explain the situation -> that could cause equiv violations here...could you please check that? I guess the SWO stands for SharedWorkOptimizer. With CTE materialization, each CTE is compiled separately. It means `materialized_cte`, `another_materialized_cte`, and the body part are compiled one by one in a dedicated manner. So, SharedWorkOptimizer has no chance as it's invoked in analyzeInternal. Just for a note. We use CTE because we need to support some cases which SharedWorkOptimizer doesn't support. An example is complex CTE + UNION ALL. We may replace CTE materialization with SharedWorkOptimizer when it becomes more mature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
