deniskuzZ commented on code in PR #4959:
URL: https://github.com/apache/hive/pull/4959#discussion_r1482842516
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java:
##########
@@ -749,6 +753,22 @@ public Object getBoolean(boolean val) {
return val;
}
+ public Object convertDateValue(Object dateValue) {
Review Comment:
1. why don't we rename it to `boolean isValidDate(String dateValue)` or
something
2. why input and output types are Object and not String
3. why this util method is in DatabaseProduct class (not in same DateUtil),
has nothing to do with it
4. why do you need double conversion, but not just return dateValue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
