dengzhhu653 commented on code in PR #4959:
URL: https://github.com/apache/hive/pull/4959#discussion_r1500279213
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java:
##########
@@ -231,25 +229,27 @@ public Long
visitIntegerLiteral(PartitionFilterParser.IntegerLiteralContext ctx)
}
@Override
- public Date visitDateLiteral(PartitionFilterParser.DateLiteralContext ctx) {
+ public String visitDateLiteral(PartitionFilterParser.DateLiteralContext ctx)
{
PartitionFilterParser.DateContext date = ctx.date();
String dateValue = unquoteString(date.value.getText());
try {
- return MetaStoreUtils.convertStringToDate(dateValue);
+ MetaStoreUtils.convertStringToDate(dateValue);
Review Comment:
We can avoid passing the invalid date down into the query filter generator
given the context here is a date, and fail from the error quickly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
