deniskuzZ commented on code in PR #4761: URL: https://github.com/apache/hive/pull/4761#discussion_r1502764575
########## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ########## @@ -416,12 +417,13 @@ private void commitTable(FileIO io, ExecutorService executor, OutputTable output Table table = null; String branchName = null; - + Expression filterExpr = Expressions.alwaysTrue(); for (JobContext jobContext : outputTable.jobContexts) { JobConf conf = jobContext.getJobConf(); table = Optional.ofNullable(table).orElse(Catalogs.loadTable(conf, catalogProperties)); branchName = conf.get(InputFormatConfig.OUTPUT_TABLE_SNAPSHOT_REF); - + filterExpr = Expressions.and(filterExpr, (Expression) SessionStateUtil.getResource(conf, Review Comment: what would be a final filter in case of multiple jobContexts? multiple duplicate filter expressions joined with `and`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org