simhadri-g commented on code in PR #4761:
URL: https://github.com/apache/hive/pull/4761#discussion_r1508000635
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java:
##########
@@ -102,12 +102,25 @@ static Expression
icebergDataFilterFromHiveConf(Configuration conf) {
if (hiveFilter != null) {
ExprNodeGenericFuncDesc exprNodeDesc = SerializationUtilities
.deserializeObject(hiveFilter, ExprNodeGenericFuncDesc.class);
- SearchArgument sarg = ConvertAstToSearchArg.create(conf, exprNodeDesc);
- try {
+ return getFilterExpr(conf, exprNodeDesc);
+ }
+ return null;
+ }
+
+ /**
+ * getFilterExpr extracts search argument from ExprNodeGenericFuncDesc and
returns Iceberg Filter Expression
+ * @param conf - job conf
+ * @param exprNodeDesc - Describes a GenericFunc node
+ * @return Iceberg Filter Expression
+ */
+ public static Expression getFilterExpr(Configuration conf,
ExprNodeGenericFuncDesc exprNodeDesc) {
+ try {
Review Comment:
done
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -416,12 +417,13 @@ private void commitTable(FileIO io, ExecutorService
executor, OutputTable output
Table table = null;
String branchName = null;
-
+ Expression filterExpr = Expressions.alwaysTrue();
for (JobContext jobContext : outputTable.jobContexts) {
Review Comment:
done
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -769,6 +771,9 @@ public void storageHandlerCommit(Properties
commitProperties, Operation operatio
}
}
+ public HiveIcebergOutputCommitter getOutputCommitter() {
+ return new HiveIcebergOutputCommitter();
+ }
@Override
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
