wecharyu commented on code in PR #5063: URL: https://github.com/apache/hive/pull/5063#discussion_r1524128589
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ########## @@ -1027,15 +1021,42 @@ public <T> List<T> getPartitionFieldsViaSqlFilter( } } + + /** Should be called with the list short enough to not trip up Oracle/etc. */ + private List<Partition> getPartitionsFromPartitionNames(String catName, String dbName, + String tblName, Boolean isView, List<String> partNameList, List<String> projectionFields, + boolean isAcidTable, GetPartitionsArgs args) throws MetaException { + // Get most of the fields for the partNames provided. + // Assume db and table names are the same for all partition, as provided in arguments. + String partNames = partNameList.stream() + .map(name -> "'" + name + "'") + .collect(Collectors.joining(",")); + String queryText = Review Comment: Yes, this query is familiar with following: https://github.com/wecharyu/hive/blob/a348e5d86adc611e4f72d386815a21a96b667ab4/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java#L448-L455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org