wecharyu commented on code in PR #5063: URL: https://github.com/apache/hive/pull/5063#discussion_r1524324359
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ########## @@ -742,14 +742,8 @@ public List<Partition> getPartitionsViaPartNames(final String catName, final Str return Batchable.runBatched(batchSize, partNames, new Batchable<String, Partition>() { @Override public List<Partition> run(List<String> input) throws MetaException { - String filter = "" + PARTITIONS + ".\"PART_NAME\" in (" + makeParams(input.size()) + ")"; - List<Long> partitionIds = getPartitionIdsViaSqlFilter(catName, dbName, tblName, Review Comment: Does not find the clues, I guess it's because there are existing `getPartitionIdsViaSqlFilter()` and `getPartitionsFromPartitionIds` methods that can be used directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org