deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1535400489
########## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ########## @@ -8810,7 +8810,8 @@ private Operator genConversionSelectOperatorByAddPartition(String dest, QB qb, O List<ExprNodeDesc> expressions = new ArrayList<>(outColumnCnt); AtomicBoolean convert = new AtomicBoolean(false); - if (inColumnCnt + staticPartitionColumnCnt != outColumnCnt) { + if (inColumnCnt + staticPartitionColumnCnt != outColumnCnt && Review Comment: previously this check was done regardless of `alwaysUnpartitioned` flag and now we moved it inside the if? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org