difin commented on code in PR #5123:
URL: https://github.com/apache/hive/pull/5123#discussion_r1533045609
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -8810,7 +8810,8 @@ private Operator
genConversionSelectOperatorByAddPartition(String dest, QB qb, O
List<ExprNodeDesc> expressions = new ArrayList<>(outColumnCnt);
AtomicBoolean convert = new AtomicBoolean(false);
- if (inColumnCnt + staticPartitionColumnCnt != outColumnCnt) {
+ if (inColumnCnt + staticPartitionColumnCnt != outColumnCnt &&
Review Comment:
I modified the check for Iceberg case as following, is it fine now?
```
if (table.getStorageHandler() != null &&
table.getStorageHandler().alwaysUnpartitioned()) {
if (inColumnCnt != outColumnCnt || staticPartitionColumnCnt >
inColumnCnt){
String reason = "Always unpartitioned table " + dest + " has " +
outColumnCnt
+ " columns, but query has " + inColumnCnt + " columns.";
throw new SemanticException(ASTErrorUtils.getMsg(
ErrorMsg.TARGET_TABLE_COLUMN_MISMATCH.getMsg(),
qb.getParseInfo().getDestForClause(dest), reason));
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
