pvary commented on code in PR #5129:
URL: https://github.com/apache/hive/pull/5129#discussion_r1539381176


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -624,6 +624,40 @@ public boolean openTransaction(String isolationLevel) {
     return result;
   }
 
+  @Override
+  public int updateParameterWithExpectedValue(Table table, String key, String 
expectedValue, String newValue)
+      throws MetaException {
+    String dml = String.format(

Review Comment:
   That's sad 😢 
   
   Then we need to fall back to directsql.
   Something like this:
   ```
      String queryText =  "UPDATE \"TABLE_PARAMS\" SET \"PARAM_VALUE\" = ? " +
               "WHERE \"TBL_ID\" = ? AND \"PARAM_KEY\" = ? AND \"PARAM_VALUE\" 
= ?";
       try (QueryWrapper query = new 
QueryWrapper(pm.newQuery("javax.jdo.query.SQL", queryText))) {
          Object[] params = new Object[4];
          params[0] = ...;
          long res = query.executeWithArray(params);
   ...
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to