pvary commented on PR #5129:
URL: https://github.com/apache/hive/pull/5129#issuecomment-2028466840
> @pvary Thanks for the reviews. One thing to mention is this change adds a
new exception message for commit conflict: `The table has been modified.
Updating expected key %s affects %d rows`. So Iceberg needs to check for this
message during commit. Let me know if you think that's not good.
>
> And btw the change has been verified with Postgres, MySQL and MS SQL
Server. I didn't manage to get a working Oracle instance.
That’s a good point. If possible we should keep the old message, so we do
not create even more confusion of versions...
The check there is like this:
```
if (e.getMessage()
.contains(
"The table has been modified. The parameter value for key '"
+ HiveTableOperations.METADATA_LOCATION_PROP
+ "' is")) {
throw new CommitFailedException(
e, "The table %s.%s has been modified concurrently", database,
tableName);
}
```
Either we can issue a query to check the new value, or change it to "the
parameter value for key ... is different"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
