zabetak commented on code in PR #5022:
URL: https://github.com/apache/hive/pull/5022#discussion_r1553243402
##########
ql/src/java/org/apache/hadoop/hive/ql/QueryState.java:
##########
@@ -88,6 +88,11 @@ public class QueryState {
*/
private final ReentrantLock resolveConditionalTaskLock = new
ReentrantLock(true);
+ /**
+ * command type that requires the authorization.
+ */
+ private HiveOperation authorizationCommandType;
+
Review Comment:
The `HiveOperation` class was explicitly introduced for authorization
purposes. Adding a separate field in `QueryState` is confusing and will be hard
to maintain. It becomes unclear when/how to update `commandType` and
`authorizationCommandType`, why we need both, when and under what context we
should use each of those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
