jfsii commented on PR #5022:
URL: https://github.com/apache/hive/pull/5022#issuecomment-2065338055
I tend to lead towards keeping things as is for subjective things (unless
there is a good reason to change).
If we do end up changing the PRE/POST hook - it might make sense to do
something like:
console.printInfo("PREHOOK: type: " (isExplain ? "EXPLAIN " : "") +
queryState.getCommandType(), false);
So we get both bits of information - and as for the contents of the proto
files maybe adding an isExplain? But as @zabetak pointed out it is pretty easy
for people to do a prefix check on the query string (and it would be backwards
compatible between versions of hive)
Just chiming in with my opinion - not sure what is the "right way" or even
if there is a "right way".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
