deniskuzZ commented on code in PR #5205:
URL: https://github.com/apache/hive/pull/5205#discussion_r1574291602
##########
service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java:
##########
@@ -66,13 +69,30 @@ public void init() {
"org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactory");
}
- private void startHiveServer() throws InterruptedException {
- // Start hive server2
- server = new HiveServer2();
- server.init(hiveConf);
- server.start();
- Thread.sleep(5000);
- System.out.println("## HiveServer started");
+ private void startHiveServer() throws Exception {
Review Comment:
that looks similar to TestHS2HttpServer#beforeTests, would be nice to
extract common code into a base class
##########
service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java:
##########
@@ -66,13 +69,30 @@ public void init() {
"org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactory");
}
- private void startHiveServer() throws InterruptedException {
- // Start hive server2
- server = new HiveServer2();
- server.init(hiveConf);
- server.start();
- Thread.sleep(5000);
- System.out.println("## HiveServer started");
+ private void startHiveServer() throws Exception {
Review Comment:
that looks similar to `TestHS2HttpServer#beforeTests`, would be nice to
extract common code into a base class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
