deniskuzZ commented on code in PR #5205: URL: https://github.com/apache/hive/pull/5205#discussion_r1574293881
########## service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java: ########## @@ -48,12 +49,14 @@ public class TestRetryingThriftCLIServiceClient { protected static ThriftCLIService service; private HiveConf hiveConf; private HiveServer2 server; + private int port = 15000; + public static final int RETRY_COUNT = 10; @Before public void init() { hiveConf = new HiveConf(); hiveConf.setVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_BIND_HOST, "localhost"); - hiveConf.setIntVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_PORT, 15000); + hiveConf.setIntVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_PORT, port); Review Comment: what's the use of it, since HS2 start is done later and free port could be different? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org