deniskuzZ commented on code in PR #4902:
URL: https://github.com/apache/hive/pull/4902#discussion_r1615538836


##########
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:
##########
@@ -285,6 +289,16 @@ public HiveConnection(String uri, Properties info) throws 
SQLException {
     this(uri, info, HiveJdbcBrowserClientFactory.get());
   }
 
+  public HiveConnection Clone() throws SQLException {

Review Comment:
   if you don't want to override Object#clone, create a copy constructor
   ````
     public HiveConnection(HiveConnection hiveConnection) {
       this(hiveConnection.getConnectedUrl(), hiveConnection.getClientInfo(), 
HiveJdbcBrowserClientFactory.get(), false);
       // These are set/updated when the session is established.
       this.sessHandle = hiveConnection.sessHandle;
       this.connParams = hiveConnection.connParams;
       this.protocol = hiveConnection.protocol;
       this.defaultFetchSize = hiveConnection.defaultFetchSize;
     }
   ````



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to