deniskuzZ commented on code in PR #4902: URL: https://github.com/apache/hive/pull/4902#discussion_r1615563125
########## jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java: ########## @@ -372,6 +372,20 @@ static int columnScale(Type hiveType, JdbcColumnAttributes columnAttributes) } } + static boolean columnSigned(Type hiveType, JdbcColumnAttributes columnAttributes) + throws SQLException { + int columnType = hiveTypeToSqlType(hiveType); + switch(columnType) { + case Types.TINYINT: Review Comment: please format the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org