SourabhBadhya commented on code in PR #5251:
URL: https://github.com/apache/hive/pull/5251#discussion_r1629517567


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -783,12 +820,59 @@ public List<FileStatus> getOutputFiles(List<JobContext> 
jobContexts) throws IOEx
         tableExecutor.shutdown();
       }
     }
+    Collection<FileStatus> dataFiles = new ConcurrentLinkedQueue<>();
+    parentDirToDataFile.forEach((parentDir, fileStatusList) -> {

Review Comment:
   Done.



##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -783,12 +820,59 @@ public List<FileStatus> getOutputFiles(List<JobContext> 
jobContexts) throws IOEx
         tableExecutor.shutdown();
       }
     }
+    Collection<FileStatus> dataFiles = new ConcurrentLinkedQueue<>();
+    parentDirToDataFile.forEach((parentDir, fileStatusList) -> {
+      if (fileStatusList.size() > 1) {
+        dataFiles.addAll(fileStatusList);
+      }
+    });
+    parentDirToDeleteFile.forEach((parentDir, fileStatusList) -> {

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to