SourabhBadhya commented on code in PR #5251:
URL: https://github.com/apache/hive/pull/5251#discussion_r1629521517
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -275,10 +277,134 @@ private static void checkResiduals(CombinedScanTask
task) {
@Override
public RecordReader<Void, T> createRecordReader(InputSplit split,
TaskAttemptContext context) {
- return new IcebergRecordReader<>();
+ if (split instanceof IcebergMergeSplit) {
Review Comment:
Done.
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -590,4 +643,135 @@ private static Schema
schemaWithoutConstantsAndMeta(Schema readSchema, Map<Integ
return TypeUtil.selectNot(readSchema, collect);
}
}
+
+ private static final class IcebergMergeRecordReader<T> extends
AbstractIcebergRecordReader<T> {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
