deniskuzZ commented on code in PR #5345:
URL: https://github.com/apache/hive/pull/5345#discussion_r1677085469
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java:
##########
@@ -308,9 +308,14 @@ public long
evictEntity(LlapDaemonProtocolProtos.EvictEntityRequestProto protoRe
LOG.debug("Starting proactive eviction.");
long time = System.currentTimeMillis();
- long markedBytes = dataCache.markBuffersForProactiveEviction(predicate,
isInstantDeallocation);
- markedBytes +=
fileMetadataCache.markBuffersForProactiveEviction(predicate,
isInstantDeallocation);
- markedBytes += serdeCache.markBuffersForProactiveEviction(predicate,
isInstantDeallocation);
+ long markedBytes = 0;
+ if (useLowLevelCache) {
Review Comment:
`SimpleBufferManager` is used for `dataCache` when `useLowLevelCache` is
`false`, so we should evict it as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
