ngsg commented on PR #5345: URL: https://github.com/apache/hive/pull/5345#issuecomment-2227645329
> `SimpleBufferManager` is used for `dataCache` when `useLowLevelCache` is `false`, so we should evict it as well @deniskuzZ, `SimpleBufferManager#markBuffersForProactiveEviction` always throws `UnsupportedOperationException`, so I excluded it when `useLowLevelCache == false`. In fact, we don't have to check `dataCache` and `fileMetadataCache` because the first if-clause (`memoryManager == null`) ensures that `dataCache instanceof LowLevelCacheImpl` and `fileMetadataCache != null`. I didn't notice it and fixed my patch to check only `serdeCache`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
