deniskuzZ commented on code in PR #5254:
URL: https://github.com/apache/hive/pull/5254#discussion_r1680588002
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/vector/HiveBatchIterator.java:
##########
@@ -144,4 +115,53 @@ public HiveBatchContext next() {
advanced = false;
return new HiveBatchContext(batch, vrbCtx, rowOffset);
}
+
+ public void fillVirtualColumns() {
Review Comment:
hm, then why it didn't complain before? you just added extra case
shouldn't it be `private` then? also maybe just `setVirtualColumns`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
