deniskuzZ commented on code in PR #5254:
URL: https://github.com/apache/hive/pull/5254#discussion_r1680607121
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergMergeRecordReader.java:
##########
@@ -52,7 +55,14 @@ public void initialize(InputSplit split, TaskAttemptContext
newContext) {
}
private CloseableIterator<T> nextTask() {
- return openGeneric(mergeSplit.getContentFile(),
getTable().schema()).iterator();
+ CloseableIterator<T> closeableIterator =
openGeneric(mergeSplit.getContentFile(), getTable().schema()).iterator();
+ if (mergeSplit.getContentFile() instanceof DeleteFile) {
+ return new
IcebergAcidUtil.MergeVirtualColumnAwareIterator<>(closeableIterator,
+
IcebergAcidUtil.createSerdeSchemaForDelete(getTable().schema().columns()),
getConf(),
Review Comment:
nit, maybe extract serde into local var for readability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
